[swig,gdal] New port #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @dg0yt you might be interested in seeing python bindings for gdal |
m-kuhn
commented
Mar 18, 2024
Comment on lines
+172
to
+182
| file(REMOVE_RECURSE | ||
| "${CURRENT_PACKAGES_DIR}/debug/Lib" | ||
| "${CURRENT_PACKAGES_DIR}/debug/Scripts" | ||
| ) | ||
| file(COPY "${CURRENT_PACKAGES_DIR}/Lib/site-packages/" DESTINATION "${CURRENT_PACKAGES_DIR}/${PYTHON3_SITE}") | ||
| # TODO: Generalize for non windows | ||
| file(COPY "${CURRENT_PACKAGES_DIR}/Scripts" DESTINATION "${CURRENT_PACKAGES_DIR}/${PYTHON3_SITE}/../../Scripts") | ||
| file(REMOVE_RECURSE | ||
| "${CURRENT_PACKAGES_DIR}/Lib/site-packages" | ||
| "${CURRENT_PACKAGES_DIR}/Scripts" | ||
| ) |
There was a problem hiding this comment.
This is certainly a hack, ideally we would convince setuptools to install into the proper prefix tools/python3 in the package directory, right now it installs into the root of the package directory. https://github.com/OSGeo/gdal/blob/a8a0fd5e526f664212dcca3204c686c768cbcc3d/swig/python/CMakeLists.txt#L207 Is where it's invoked.
Also, the current (hacky) destination for scripts is handcoded, relative to PYTHON3_SITE which is brittle too.
m-kuhn
commented
May 12, 2024
| if os.name == 'nt': | ||
| os.add_dll_directory('@PACKAGE_DLL_DIR@') | ||
| os.add_dll_directory('@INSTALLED_DLL_DIR@') |
There was a problem hiding this comment.
This should actually be ensured by other means
m-kuhn
force-pushed
the
swig
branch
2 times, most recently
from
4db06bf to
869c722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.